I’ma happy 3.0.12 user
My weblog uses WP 2.6

I tried 3.1.0 beta 5 and got

Warning: Invalid argument supplied for foreach() in /foo/bar/wp-content/plugins/in-series/in-series-config.php on line 45

Warning: Invalid argument supplied for foreach() in /foo/bar/wp-content/plugins/in-series/in-series-config-advanced.php on line 20

Any idea

Luc

thanks

a small request… I’d like to change the displayed position of In-Series to directly after the TITLE, and not after the_content.

Is there a way of doing this with a template tag?

Thanks

is_single() && InSeries::adv_CurrentSeries($post->ID)

Cheers for the plugin - wouldn’t be without it.

BTW, if the series went away, so would the widget registration so your point #3 shouldn’t be a problem. The widget would disappear, although all the options would still be in the db - much the same as deactivating a plugin without removing the widget first.

Eeeeh… I’d have to test that. The scenario I’m envisioning is that the user has only the Series List widget installed, and then removes their only post… then their sidebar either reverts to the default (and stays that way), or switches between the default sidebar and the custom/widget sidebar (depending on if they add a new series). You may very well be technically correct; in any case, I have to commend you for a very interesting way to solve the problem. :)

Another BTW - if you use the get_args($args) function, you have available all of the arguments as vars, i.e., $before_widget, $before_title, etc. rather than having to get them from the array. Just a little easier, IMHO.

get_args() isn’t a PHP or WordPress-defined function; I assume you mean extract($args). I concur that explicit array references are not as pretty as nice, succinct variable references. However, from a clarity and defensive coding standpoint, I much prefer explicit array references. Specifically, someone reading the code knows where the variable came from (clarity), and you won’t accidentally overwrite your local variables if your caller decides to add new values to the array (security). Yes, you can tell extract() to not clobber existing variables (it’s not the default), but you still pollute your namespace — as soon as some schmuck decides to use an uninitialized variable, you have a potential vulnerability in your code. :)

I really appreciate you taking the time to go through the code base and give your thoughts; please feel free to get in touch with me via e-mail if you’d like to discuss anything else. I can always use more help!

BTW, if the series went away, so would the widget registration so your point #3 shouldn’t be a problem. The widget would disappear, although all the options would still be in the db - much the same as deactivating a plugin without removing the widget first.

The other two reasons, though, are enough arguments against doing it as I suggested.

And duh - having a blank sidebar widget would certainly be an indication to take it out, wouldn’t it? LOL

Another BTW - if you use the get_args($args) function, you have available all of the arguments as vars, i.e., $before_widget, $before_title, etc. rather than having to get them from the array. Just a little easier, IMHO.

I prefer to blame the system for being stupid before blaming users. ;)

Conditional registration is a thought that had not occurred to me, and it’s a novel idea, but I think it could be confusing and potentially harmful. Specifically, I can envision:

• Users reporting the fact that the widget is not available as a bug
• Users not using the series widget, because it’s not immediately available after installation
• Users creating a series, adding the widget, then deciding they didn’t want that series… at which point, we’re in a broken state (unregistered widget on the sidebar).

What I can do is make it so that the widget will still output its header, even when there’s no content. Given the header, I think that most folks will know “hey, that spot’s empty because I don’t have any series yet; maybe I should go write one, or take that widget out.” :)